-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: rewrite command descriptions #727
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
netmilk
reviewed
Jan 15, 2025
netmilk
reviewed
Jan 15, 2025
fix typos Co-authored-by: Adam Kliment <[email protected]>
netmilk
requested changes
Jan 15, 2025
vladfrangu
reviewed
Jan 15, 2025
add missing quotes in descriptions change double quotes to single quotes throughout descriptions for consistency fixed KeyValueStore to key-value store Consisteny regarding login requirement
…cli into command-description-rewrite
Co-authored-by: Adam Kliment <[email protected]>
B4nan
requested changes
Jan 15, 2025
Removed mentions of creating named dataset & alligned it with kvs create description for consistency change the way description of push is written Rewrite pull command description to remove mentions of Web IDE files
B4nan
reviewed
Jan 15, 2025
Fix typo (missing periods) Remove trailing \n at the end of description Add missing periods Fix inconsistency in run commands
B4nan
approved these changes
Jan 15, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
apart from the requires login
thing its all good from my end
netmilk
approved these changes
Jan 15, 2025
vladfrangu
approved these changes
Jan 15, 2025
I'll merge this as is, please open new PRs if you spot anything else remaining! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rewrites command descriptions.
Changes Dataset to dataset when appropriate within descriptions.
Changes Key-value store to key-value store when appropriate within descriptions.